Refactor sudo handling for package installation#83
Open
tannevaled wants to merge 3 commits intopkgxdev:mainfrom
Open
Refactor sudo handling for package installation#83tannevaled wants to merge 3 commits intopkgxdev:mainfrom
tannevaled wants to merge 3 commits intopkgxdev:mainfrom
Conversation
proposal to fix sudo handling
There was a problem hiding this comment.
Pull request overview
This PR proposes to refactor how pkgm decides when to invoke pkgx directly vs wrapping it with sudo, specifically around installs targeting /usr/local.
Changes:
- Introduces explicit
isRootandSUDO_USERdetection inquery_pkgx. - Emits a warning when installing to
/usr/localas root without being invoked viasudo. - Changes the conditions under which
/usr/bin/sudois used and how thesudoarguments are constructed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+311
to
+319
| const needs_sudo_backwards = | ||
| install_prefix().string == "/usr/local" && !isRoot && !sudoUser; | ||
|
|
||
| let cmd = pkgx; | ||
|
|
||
| if (needs_sudo_backwards) { | ||
| cmd = "/usr/bin/sudo"; | ||
| const user = Deno.env.get("USER")!; | ||
| args.unshift("-u", user, pkgx); |
Contributor
There was a problem hiding this comment.
this one seems like the problem; we need drop privileges so we don't mess up a user's permissions, i believe.
Comment on lines
315
to
323
|
|
||
| if (needs_sudo_backwards) { | ||
| cmd = "/usr/bin/sudo"; | ||
| const user = Deno.env.get("USER")!; | ||
| args.unshift("-u", user, pkgx); | ||
| } | ||
|
|
||
| const proc = new Deno.Command(cmd, { | ||
| args: [...args, "--json=v1"], |
Contributor
There was a problem hiding this comment.
this seems like a lateral fix that was either always needed, or isn't now needed.
|
|
||
| if (needs_sudo_backwards) { | ||
| cmd = "/usr/bin/sudo"; | ||
| const user = Deno.env.get("USER")!; |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+312
to
+322
| const needs_sudo_backwards = | ||
| prefix == "/usr/local" && !isRoot && !sudoUser; | ||
|
|
||
| let cmd = pkgx; | ||
|
|
||
| if (needs_sudo_backwards) { | ||
| cmd = "/usr/bin/sudo"; | ||
| const user = Deno.env.get("USER")!; | ||
| args.unshift("-u", user, pkgx); | ||
| } | ||
|
|
Comment on lines
+319
to
+320
| const user = Deno.env.get("USER")!; | ||
| args.unshift("-u", user, pkgx); |
Comment on lines
+316
to
324
|
|
||
| if (needs_sudo_backwards) { | ||
| cmd = "/usr/bin/sudo"; | ||
| const user = Deno.env.get("USER")!; | ||
| args.unshift("-u", user, pkgx); | ||
| } | ||
|
|
||
| const proc = new Deno.Command(cmd, { | ||
| args: [...args, "--json=v1"], |
|
|
||
| if (needs_sudo_backwards) { | ||
| cmd = "/usr/bin/sudo"; | ||
| const user = Deno.env.get("USER")!; |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+312
to
+320
| const needs_sudo_backwards = | ||
| prefix == "/usr/local" && !isRoot && !sudoUser; | ||
|
|
||
| let cmd = pkgx; | ||
|
|
||
| if (needs_sudo_backwards) { | ||
| if (!Deno.env.get("SUDO_USER")) { | ||
| if (Deno.uid() == 0) { | ||
| console.error( | ||
| "%cwarning", | ||
| "color:yellow", | ||
| "installing as root; installing via `sudo` is preferred", | ||
| ); | ||
| } | ||
| cmd = pkgx; | ||
| } else { | ||
| args.unshift("-u", Deno.env.get("SUDO_USER")!, pkgx); | ||
| } | ||
| cmd = "/usr/bin/sudo"; | ||
| const user = Deno.env.get("USER")!; | ||
| args.unshift("-u", user, pkgx); |
Comment on lines
+318
to
321
| cmd = "/usr/bin/sudo"; | ||
| const user = Deno.env.get("USER")!; | ||
| args.unshift("-u", user, pkgx); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proposal to fix sudo handling